Skip to content

[skip-changelog] Added missing docs for 'recipe.hooks.prebuild.NUMBER.pattern' #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 11, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Add missing docs for recipe.hooks.prebuild.NUMBER.pattern build hook.
Fix #1910

What is the current behavior?

No changes.

What is the new behavior?

No changes.

Does this PR introduce a breaking change, and is titled accordingly?

No

@cmaglie cmaglie added type: enhancement Proposed improvement topic: documentation Related to documentation for the project priority: low Resolution is a low priority criticality: low Of low impact labels Oct 11, 2022
@cmaglie cmaglie self-assigned this Oct 11, 2022
@cmaglie cmaglie requested review from per1234 and umbynos October 11, 2022 10:16
@umbynos umbynos changed the title Added missing docs for 'recipe.hooks.prebuild.NUMBER.pattern' [skip-changelog] Added missing docs for 'recipe.hooks.prebuild.NUMBER.pattern' Oct 11, 2022
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe better to wait for the doc expert @per1234 ❤️

Copy link

@carlosperate carlosperate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR!
LGTM as well, it's the hook I've been using so far (as noted in #1910) 👍

@cmaglie cmaglie merged commit 589cbcc into arduino:master Oct 12, 2022
@cmaglie cmaglie deleted the docs_update branch October 12, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: low Of low impact priority: low Resolution is a low priority topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A platform hook to run something before the preprocessor?
3 participants